-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate aws nuke #483
Conversation
Signed-off-by: Maggie Chen <[email protected]>
I am not sure what your intention is here and I cannot view the issue but this is walk backwards on this tool. I will not be accepting this PR as it stands. If you'd like to open an issue and explain the problem in more detail or get me access to the redhat issue. |
@ekristen Hey Erik, sorry I didn't realize that you don't have permission to the redhat issue. Let me summarize the purpose of this PR. Essentially the description for that issue is:
Cluster cleaner is an internal repository that we use to clean up aws resources like clusters, roles, etc. I'm not sure if you can view it but I'll just paste the link here: https://gitlab.cee.redhat.com/service/uhc-clusters-cleaner In cluster cleaner, we would need to use the cmd, awsutil and config, hence this PR. We are hoping to make cluster cleaner switch to this repository, but would need to port those over like the used cmds. Regarding the next step, would you prefer me to open an issue under this repository and we start some discussions on what's the best approach? |
I'll draft a new PR with only affected changes and then I'll open an issue on this, I'll see how much I can adopt on the cluster cleaner side. |
It's not clear to me why you want to open a PR. This is the new active aws-nuke, you simply need to source your binaries from this project and see the 1 breaking change which is that you need to pass I've got no access to the issue or the uhc-clusters-cleaner either, that seems to be private as well. If you are using golang, you will need to port your project over to use the new code here, not the other way around. |
Agreed @ekristen , I think I can start with replacing the old aws-nuke with the new project & new nuke. Frankly speaking I should do that first to be honest. Will keep you posted on how that goes. |
@chenz4027 feel free to reach out to me directly via email if you'd like to discuss it more. Generally speaking I'm open to making the tool more friendly for programmatic access. |
Thanks so much @ekristen 👍 Yeah I will definitely shoot an email if I ran into any issues. Appreciate your efforts for all the work you did in the aws-nuke project, it's truely amazing! |
You are welcome. Thank you for your kind words. It's greatly appreciated. |
https://issues.redhat.com/browse/OCM-12734